fix(core): add translations on the login page #42100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Login form has translations from
core
app.script('core')
on the login template doesn't load translations becauseaddScript
ignores translations for thecore
app. Translations should be loaded implicitly.Before
Util::addTranslations('core');
was always a part ofinitTemplateEngine
, but it was changed on the mentioned PR.Screenshots
Checklist